Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub action: provide deploy script #3741

Closed
de-jcup opened this issue Dec 13, 2024 · 2 comments · Fixed by #3734
Closed

GitHub action: provide deploy script #3741

de-jcup opened this issue Dec 13, 2024 · 2 comments · Fixed by #3734

Comments

@de-jcup
Copy link
Member

de-jcup commented Dec 13, 2024 •
edited
Loading

Situation

There are many steps necessary to deploy the github action

  • npm install
  • npm run build
  • npm test
  • manual check only index.js has been changed
    • if others, deployment is (potentially) not okay
    • if index.js is missing it is not a deployment
    • means may only be index.js
  • add all (means only index.js) to stage
  • commit with deployment info
  • push to remote repo

Wanted

An easy way to automate this.

Solution

Provide a ./deploy.sh script which does automate this.
@de-jcup de-jcup mentioned this issue Dec 13, 2024
Merged
de-jcup added a commit that referenced this issue Dec 13, 2024
@de-jcup
Provide deploy.sh script for deployments #3741
eeda133
de-jcup added a commit that referenced this issue Dec 13, 2024
@de-jcup
Provide deploy.sh script for deployments #3741
4ac750f
@de-jcup
Copy link
Member Author

de-jcup commented Dec 17, 2024

We have here a .github/workflows/release-github-action.yml which automates this.
Will remove my changes and close this issue.

@de-jcup de-jcup closed this as completed Dec 17, 2024
@de-jcup
Copy link
Member Author

de-jcup commented Dec 17, 2024

The README file shall have information about release workflow.

@de-jcup de-jcup reopened this Dec 17, 2024
de-jcup added a commit that referenced this issue Dec 17, 2024
@de-jcup
Removed deploy.sh script and updated documentation #3741
1118ff7 
- we have already the github action workflow
  `.github/workflows/release-github-action.yml` which
  automates the deployment process so removed deploy.sh
- added information about deployment workflow inside README.adoc
- fixed typo in README.adoc
de-jcup added a commit that referenced this issue Dec 17, 2024
@de-jcup
Removed deploy.sh script and updated documentation #3741
1291fb3 
- we have already the github action workflow
  `.github/workflows/release-github-action.yml` which
  automates the deployment process so removed deploy.sh
- added information about deployment workflow inside README.adoc
- updated some documentation part and fixed typo in README.adoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix output problem #3481 mercedes-benz/sechub
1 participant
@de-jcup