Merge pull request #3642 from mercedes-benz/feature-3641-make-client-…

…build-reproducible Feature 3641 make client builds reproducible #3641
mercedes-benz · Nov 25, 2024 · 7338aea · 7338aea
2 parents 847255d + 2072612
commit 7338aea
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/gradle/build-versioning.gradle b/gradle/build-versioning.gradle
@@ -63,7 +63,7 @@ def buildVersionFiles(){
     def noStagedChanges = stagedChanges.getAllChanges().isEmpty()
     def hasChanged = !noUnstagedChanges || !noStagedChanges
     def buildNumber = getBuildNr()
-    def docsTimeStamp = getLocalBuildNr()
+    def docsTimeStamp = getTimeStamp()
     def currentGitCommit = git.head().abbreviatedId
 
     // ------------------------
@@ -336,8 +336,8 @@ def buildVersionString(commitTag, boolean hasChanged, buildNumber){
         calcversion = calcversion - "-libraries"
         calcversion = calcversion - "-pds-tools"
         calcversion = calcversion - "-pds"
-        calcversion = calcversion - "-server"
         calcversion = calcversion - "-web-server"
+        calcversion = calcversion - "-server"
         calcversion = calcversion - "-checkmarx-wrapper"
         calcversion = calcversion - "-owaspzap-wrapper"
         calcversion = calcversion - "-prepare-wrapper"
@@ -349,29 +349,31 @@ def buildVersionString(commitTag, boolean hasChanged, buildNumber){
     if (hasChanged){
         calcversion = "${calcversion}-dirty"
     }
-    calcversion = "${calcversion}-${buildNumber}"
+    if (buildNumber != "") {
+        calcversion = "${calcversion}-${buildNumber}"
+    }
     return calcversion
 }
 
 def getBuildNr(){
-    if (getServerBuildNr()!=null){
+    if (getServerBuildNr()!=null) {
         return "b"+getServerBuildNr()
-    }else{
+    } else {
         if (project.hasProperty('sechub.build.timestamp')){
             if (project.getProperty('sechub.build.timestamp')=="false"){
                 return "latest"
             }
         }
-        return getLocalBuildNr()
+        return ""
     }
 }
 
 def getServerBuildNr(){
     return System.getenv('BUILD_NUMBER' )
 }
 
-def getLocalBuildNr() {
-    return new Date().format('yyyyMMddHHmmss')
+def getTimeStamp() {
+    return new Date().format("yyyy-MM-dd HH:mm ('UTC'X)")
 }
 
 

diff --git a/sechub-cli/build_go.sh b/sechub-cli/build_go.sh
@@ -64,7 +64,8 @@ init_go_modules
 cd "$SRC_PATH/main"
 
 export CGO_ENABLED=0  # This forces statically linked binaries
-GO_LD_FLAGS="-s -w"   # strip (reduce size): disable debug symbol table / disable DWARF generation
+GO_LD_FLAGS="-s -w -buildid=" # strip (reduce size): disable debug symbol table / disable DWARF generation
+GO_COMPILE_FLAGS="-trimpath"  # Aim to make builds reproducible
 
 for platform in "${platforms[@]}" ; do
     platform_split=(${platform//\// })
@@ -82,7 +83,7 @@ for platform in "${platforms[@]}" ; do
     fi
 
     echo "> building $targetSubFolder"
-    go build -ldflags="$GO_LD_FLAGS" -o "$buildDir/$output_name" .
+    go build $GO_COMPILE_FLAGS -ldflags="$GO_LD_FLAGS" -o "$buildDir/$output_name" .
     if [ $? -ne 0 ]; then
         echo 'Go build failed because of an error'
         exit 1