This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
Implement Factory to reduce custom code #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes use of implementation at github.com/kubernetes/kube-state-metrics/pull/1644. Adds features of kube-state-metrics like sharding. Signed-off-by: Schlotter, Christian <[email protected]>
chrischdi
force-pushed
the
chrischdi/ksm-pr-adopt
branch
from
ba58430 to
b97b494
Compare
|
Did run the foss-scan manually which did not show any violations. Fix for the foss-scan will be adressed in a separate PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of implementation at
github.com/kubernetes/kube-state-metrics/pull/1644.
Adds features of kube-state-metrics like sharding.
Signed-off-by: Schlotter, Christian [email protected]