Support custom GitHub token environment variable name #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KeisukeYamashita <[email protected]>
KeisukeYamashita
force-pushed
the
support-custom-github-token-env-var-name
branch
from
ec68a58 to
13d4a8b
Compare
KeisukeYamashita
requested review from
babarot,
dtan4,
drlau and
micnncim
as code owners
KeisukeYamashita
changed the title
micnncim
reviewed
Feb 20, 2022
| @@ -69,10 +69,11 @@ type service struct { | |||
| // NewClient returns Client initialized with Config | |||
| func NewClient(cfg Config) (*Client, error) { | |||
| token := cfg.Token | |||
| token = strings.TrimPrefix(token, "$") | |||
| if token == EnvToken { | |||
| token = os.Getenv(EnvToken) | |||
There was a problem hiding this comment.
Since now the EnvToken is used only in testing, we can remove the variable.
There was a problem hiding this comment.
Yeah, true. Let me remove it 👍
There was a problem hiding this comment.
Thank you for your review, removed → e5e8b67
Signed-off-by: KeisukeYamashita <[email protected]>
|
Thank you 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
If the token with
$are configured, lookup the environment variable.WHY
For #111.
In current implementation, the
tfnotifyonly supportsGITHUB_TOKENand users can't specify a environment variable of their own.