-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Watts WFHT-RF thermostat #2648
Conversation
Not sure where we are - I am waiting for a cleanup/rebase and force push. I realize everybody is busy, and this is hard, so I don't mean to press you about time - just saying that so you aren't waiting for me while I wait for you! |
Introduce constants instead of magic numbers, compute chksum while decoding.
f162b5d
to
49710cf
Compare
Still have not found time to update the doc, which I believe is now the only thing missing. There are some other pending reviews that you can close. |
@gdt, @zuckschwerdt, not sure how to improve the doc more at this point. |
The line |
Thanks, done! I found and fixed another pointer related issue too and retested with both live and recorded input. Compiles and runs as expected. Please let me know if there are any other blockers (doc, style) or if this is good to go. |
closes #2230
Added the chksum check.
Test output: