Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Watts WFHT-RF thermostat #2648

Merged
merged 18 commits into from
Mar 1, 2024

Conversation

aadnehovda
Copy link
Contributor

@aadnehovda aadnehovda commented Sep 29, 2023

closes #2230

Added the chksum check.

Test output:

C:\Users\ahovda\source\repos\rtl_433_build>src\Debug\rtl_433.exe -s1M -R0 -R247
rtl_433 version nightly-113-g237c8bc4 branch watts_thermostat at 202309291130 inputs file rtl_tcp RTL-SDR SoapySDR
Use -h for usage help and see https://triq.org/ for documentation.
Trying conf file at "C:\Users\ahovda\source\repos\rtl_433_build\src\Debug\rtl_433.conf"...
Trying conf file at "C:\Users\ahovda\AppData\Local\rtl_433\rtl_433.conf"...
Trying conf file at "C:\ProgramData\rtl_433\rtl_433.conf"...
Disabling all device decoders.
[Protocols] Registered 1 out of 247 device decoding protocols [ 247 ]
Found Rafael Micro R820T/2 tuner
[SDR] Using device 0: Realtek, RTL2838UHIDIR, SN: 00000001, "Generic RTL2832U OEM"
Exact sample rate is: 1000000.026491 Hz
Allocating 15 (non-zero-copy) user-space buffers
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
time      : 2023-09-30 11:19:06
Model     : Watts-WFHTRF ID        : 28082
Pairing   : 1            Temperature: 25.6 C       Setpoint  : 22.1 C        Integrity : CHECKSUM
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
time      : 2023-09-30 11:19:06
Model     : Watts-WFHTRF ID        : 28082
Pairing   : 1            Temperature: 25.5 C       Setpoint  : 22.1 C        Integrity : CHECKSUM
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
time      : 2023-09-30 11:19:06
Model     : Watts-WFHTRF ID        : 28082
Pairing   : 1            Temperature: 25.6 C       Setpoint  : 22.1 C        Integrity : CHECKSUM
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
time      : 2023-09-30 11:19:07
Model     : Watts-WFHTRF ID        : 28082
Pairing   : 1            Temperature: 25.6 C       Setpoint  : 22.1 C        Integrity : CHECKSUM
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
time      : 2023-09-30 11:19:07
Model     : Watts-WFHTRF ID        : 28082
Pairing   : 0            Temperature: 25.6 C       Setpoint  : 22.1 C        Integrity : CHECKSUM
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
time      : 2023-09-30 11:19:10
Model     : Watts-WFHTRF ID        : 28082
Pairing   : 0            Temperature: 25.6 C       Setpoint  : 22.1 C        Integrity : CHECKSUM
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
time      : 2023-09-30 11:19:13
Model     : Watts-WFHTRF ID        : 28082
Pairing   : 0            Temperature: 25.5 C       Setpoint  : 22.1 C        Integrity : CHECKSUM

docs/LINKS.md Outdated Show resolved Hide resolved
src/devices/govee.c Outdated Show resolved Hide resolved
src/devices/watts_thermostat.c Outdated Show resolved Hide resolved
src/devices/watts_thermostat.c Outdated Show resolved Hide resolved
src/devices/watts_thermostat.c Outdated Show resolved Hide resolved
src/devices/watts_thermostat.c Outdated Show resolved Hide resolved
src/devices/watts_thermostat.c Outdated Show resolved Hide resolved
src/devices/watts_thermostat.c Outdated Show resolved Hide resolved
src/devices/watts_thermostat.c Outdated Show resolved Hide resolved
src/devices/watts_thermostat.c Outdated Show resolved Hide resolved
src/devices/watts_thermostat.c Outdated Show resolved Hide resolved
@gdt
Copy link
Collaborator

gdt commented Oct 14, 2023

Not sure where we are - I am waiting for a cleanup/rebase and force push. I realize everybody is busy, and this is hard, so I don't mean to press you about time - just saying that so you aren't waiting for me while I wait for you!

@aadnehovda
Copy link
Contributor Author

Not sure where we are - I am waiting for a cleanup/rebase and force push. I realize everybody is busy, and this is hard, so I don't mean to press you about time - just saying that so you aren't waiting for me while I wait for you!

Still have not found time to update the doc, which I believe is now the only thing missing. There are some other pending reviews that you can close.

@zuckschwerdt zuckschwerdt changed the title Watts thermostat support Add support for Watts WFHT-RF thermostat Nov 8, 2023
@aadnehovda
Copy link
Contributor Author

@gdt, @zuckschwerdt, not sure how to improve the doc more at this point.

@zuckschwerdt
Copy link
Collaborator

The line bitbuffer_search(bitbuffer, row, 0, &preamble_pattern, should be bitbuffer_search(bitbuffer, row, 0, preamble_pattern, and the file needs a newline at the end.

@aadnehovda
Copy link
Contributor Author

The line bitbuffer_search(bitbuffer, row, 0, &preamble_pattern, should be bitbuffer_search(bitbuffer, row, 0, preamble_pattern, and the file needs a newline at the end.

Thanks, done! I found and fixed another pointer related issue too and retested with both live and recorded input. Compiles and runs as expected. Please let me know if there are any other blockers (doc, style) or if this is good to go.

@zuckschwerdt zuckschwerdt merged commit e2f5c8e into merbanan:master Mar 1, 2024
6 checks passed
@aadnehovda aadnehovda deleted the watts_thermostat branch March 1, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help decoding Watts Thermostat
3 participants