Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for revolt energy monitor nc-5462 #2361

Merged
merged 11 commits into from
Feb 16, 2023

Conversation

nicolaihess
Copy link
Contributor

Power Plug Energy Monitor NC-5642 (from www.revolt-power.de).

Copy link
Collaborator

@zuckschwerdt zuckschwerdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good, some style changes though :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
man/man1/rtl_433.1 Outdated Show resolved Hide resolved
src/devices/revolt_nc5462.c Outdated Show resolved Hide resolved
src/devices/revolt_nc5462.c Outdated Show resolved Hide resolved
src/devices/revolt_nc5462.c Outdated Show resolved Hide resolved
src/devices/revolt_nc5462.c Outdated Show resolved Hide resolved
src/devices/revolt_nc5462.c Outdated Show resolved Hide resolved
src/devices/revolt_nc5462.c Outdated Show resolved Hide resolved
src/devices/revolt_nc5462.c Outdated Show resolved Hide resolved
@merbanan
Copy link
Owner

merbanan commented Feb 3, 2023

And send some signal samples if that has not been sent.

@nicolaihess
Copy link
Contributor Author

Thanks for the review and feedback. I will try to apply the changes.
And I am about to add signal samples and device descriptions on rtl_433_tests
(Should have read the contribution page first :) )

@nicolaihess nicolaihess force-pushed the device_revolt_energy_nc5462 branch from f44c227 to c425959 Compare February 4, 2023 21:54
@zuckschwerdt zuckschwerdt merged commit 3b1cb4f into merbanan:master Feb 16, 2023
@zuckschwerdt
Copy link
Collaborator

Merge with some changes on top. Only noticeable changes are:

  • "model" is now "Revolt-NC5462"
  • "detect_mode" renamed to "button" with 0/1 output like in other decoders.

@nicolaihess
Copy link
Contributor Author

thanks for finishing and taken the pull request.

andrewjw pushed a commit to andrewjw/rtl_433 that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants