Add support for new revision of Govee H5054 water leak detector #2273
Conversation
src/devices/govee.c
Outdated
| GOVEE_WATER_LEAK = 2, | ||
| } govee_h5054_event_t; | ||
|
|
||
| static int govee_decode_h5054(r_device *decoder, bitbuffer_t *bitbuffer) |
There was a problem hiding this comment.
name it govee_h5054_decode, add a doc-comment
include/rtl_433_devices.h
Outdated
| @@ -231,6 +231,7 @@ | |||
| DECL(fineoffset_wn34) \ | |||
| DECL(rubicson_pool_48942) \ | |||
| DECL(badger_orion) \ | |||
| DECL(govee_h5054) | |||
There was a problem hiding this comment.
needs a \ at the end
There was a problem hiding this comment.
fyi - it seems like clang-format strips it out, but i added it back in manually
|
@zuckschwerdt , has @jasonmichalski managed to resolve your review comments? I'd love to see this get merged as some of my newer sensors aren't sending quarterly battery updates (and I'm guessing it's related to the updated firmware). |
|
Yes, this is good. To be merged soon. |
|
I'm unable to pull in any Protocols above 223 on v22.11 on my computer or on my separate Home Assistant device. Instead, while trying to use the Govee 5054 Protocol 231 that I believe was the result of Issue 2273 (the one I'm currently writing this message in), I receive the error: "Protocol number specified (231) is larger than number of protocols". Has anyone else had this problem while trying to read from the Govee 5054 Protocol 231? I'm considering starting an issue -- search currently pulls up 0 matches in Issues at the moment -- but imagine I'm probably just doing something stupid as an rtl_433 newbie. |
|
There are 223 protocols in release 22.11. You need a newer version for e.g. 231. See https://triq.org/rtl_433/BUILDING.html |
|
This is exactly what I meant re: newbie growing pains. Thanks! |
This adds support for the updated protocol used by newer revisions of the Govee H5054 water leak detector.
Closes #2265