-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Vauno EN8822C - working #2231
Conversation
Trying to add the battery bits for the device. I have found the battery bit in two places as follows (I think byte 1, bit 1 and byte 4, bit 4):
As shown in the bitbench here. Any suggestions for how to properly calculate the checksum with the bad battery bit? |
Add a single nibble like this: |
Thanks! Fixed and working. |
Am I OK to close my PR, that doesn't break this one? |
I've been testing this for a couple of days, it seemed to work until it got cold last night, and it stopped getting updates once the temperature dropped below 0C. The receiver that came with it continued to get updates, and the receiver is near my RTL antenna, so I don't think it's a hardware issue. And once the temp got up to 0.1C this morning, it started getting updates again. |
@clinta Thanks for testing! I too see some missed readings due to a bad checksum. Doing a sampling with Upon more analysis it looks like the error is in the checksum calculation:
So, I added See updated code with the fix that is tested and working on my setup with all checksums passing now. |
Awesome. I'll build this and see if I keep getting readings tonight. |
Getting every 50 second reading while sampling now. Much better. @clinta Thanks for helping identify the problem! Please let me know if this improves your readings too. |
Working great now. Temperature is continuing to drop and I'm getting updates at -1.8C now. |
Git continues to confuse me - has this been merged into rtl433 yet? |
Still open, sorry. I need to find time to merge a few new device PRs. |
Oh, no rush - thanks for all the work you do on this! |
Tested on my system, works nice, thank you for a valuable contribution! |
Co-authored-by: Jamie Barron <[email protected]>
Co-authored-by: Jamie Barron <[email protected]>
Fixed up temperature, humidity, and checksum. Tested and working on my system.