Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support AVE TPMS #1909

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Add support AVE TPMS #1909

merged 4 commits into from
Dec 20, 2021

Conversation

charestp
Copy link
Contributor

Add support for AVE TPMS device. Device information can be found at:
http://www.avetechnology.com/index.php?unit=products&lang=en&act=view&id=23

@zuckschwerdt
Copy link
Collaborator

This looks great! Very interesting about the different scaling mode. I wonder if other sensors have something like this too.

  • There is one stray fprintf.
  • The battery_ok needs to be an int (0/1) or float (0-1). Do all values < 6 really map to 1 (100%) or is it a gauge?

@charestp
Copy link
Contributor Author

charestp commented Dec 18, 2021 via email

@zuckschwerdt
Copy link
Collaborator

zuckschwerdt commented Dec 18, 2021

Yes, add more commits (we squash on merge) if you like. Amend and force push is also fine.

Either the receiver does not care to distinguish high battery levels, or it's fewer bits (e.g 1 bit for weak, 1 bit for low, otherwise good)?
Best not to throw information away. If you'd say battery is 3 bits then maybe a float with (8-batt) * 0.125f (so we ge a linear 0-1 range).

The last flag bit could be an idle update vs running-mode, perhaps?
If you are still looking for the other two bits: we expect to see a rapid deflation warning bit and maybe a general warning or over-heated bit.

@charestp
Copy link
Contributor Author

I decided to change to double value and use 1.0, 0.75 and 0.25 for battery. That would be aligned with my observation of 4/4 (<6), 3/4 (6) and 1/4 (7) bars on the battery icon. I've not been able to come with a linear interpretation of those bits.

For last flags bit, I've always observed a value of 010 from the sensor. When I generated my own signal to transmit to the receiver, I saw no change on the screen for all values. That's why I kept the information as flags.

@zuckschwerdt
Copy link
Collaborator

Thanks. battery_level is fine.

I just noticed the kPa to PSI conversion factor. We always try to output the native value and encourage user to use e.g. -C cutomary to get all sensors in F/PSI/Mi.
With the conversion formula there is no true native value. But heads-up: we might remove that conversion and change to pressure_kPa on some future cleanup.

@zuckschwerdt zuckschwerdt merged commit 094707d into merbanan:master Dec 20, 2021
zuckschwerdt pushed a commit that referenced this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants