Fix warnings about size_t being cast to a narrower type #1875
+35
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obones
commented
Nov 16, 2021
| @@ -63,7 +63,7 @@ static void gpsd_client_event(struct mg_connection *nc, int ev, void *ev_data) | |||
| // Success | |||
| fprintf(stderr, "GPSd Connected...\n"); | |||
| if (ctx->init_str && *ctx->init_str) { | |||
| mg_send(nc, ctx->init_str, strlen(ctx->init_str)); | |||
| mg_send(nc, ctx->init_str, (int)strlen(ctx->init_str)); | |||
There was a problem hiding this comment.
This one should not be required if mongoose was consistent in its methods declarations: mg_send_http_chunk, mg_send_websocket_frame and almost all others take a size_t, but for some reason mg_send does not...
obones
commented
Nov 16, 2021
| @@ -1090,7 +1090,7 @@ static void http_broadcast_send(struct http_server_context *ctx, char const *msg | |||
| mg_set_timer(nc, mg_time() + KEEP_ALIVE); // reset keep alive timer | |||
| } | |||
| else if (cctx && !cctx->is_chunked) { | |||
| mg_send(nc, msg, len); | |||
| mg_send(nc, msg, (int)len); | |||
There was a problem hiding this comment.
This one should not be required if mongoose was consistent in its methods declarations: mg_send_http_chunk, mg_send_websocket_frame and almost all others take a size_t, but for some reason mg_send does not...
zuckschwerdt
force-pushed
the
master
branch
2 times, most recently
from
8e31ece to
e42ad33
Compare
obones
force-pushed
the
warnings_size_t_to_narrower_type
branch
from
30e27ae to
7c3ef9e
Compare
|
I have just rebased this branch on the latest master, please let me know if this is still of interest |
obones
force-pushed
the
warnings_size_t_to_narrower_type
branch
from
7c3ef9e to
4bb48c9
Compare
zuckschwerdt
force-pushed
the
master
branch
2 times, most recently
from
93031a1 to
ed794ec
Compare
…ables because system functions like fread/snprintf/malloc all work with size_t
… cannot be changed, make the cast explicit
obones
force-pushed
the
warnings_size_t_to_narrower_type
branch
from
4bb48c9 to
2530ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few C4267 warning as reported in #1866 because the x64 target defines
size_tas a 64 bit unsigned integer.