Extend decoded values + HCA #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jedi7
commented
Jan 27, 2021
jedi7
commented
- add support for BCD value decoding and 64bit values
- add support for H.C.A
- add support for OnTime and Operation Time
* add support for BCD value decoding and 64bit values * add support for H.C.A * add support for OnTime and Operation Time
merbanan
reviewed
Jan 27, 2021
| @@ -310,7 +330,7 @@ static data_t *append_val(data_t *data, enum UnitType unit_type, uint8_t value_t | |||
| fprintf(stderr, "M-Bus: Program error, exp (%d) is out of bounds", exp); | |||
| return data; | |||
| } | |||
| float fvalue = val * pow10_table[exp]; | |||
| double fvalue = val * pow10_table[exp]; | |||
There was a problem hiding this comment.
Not fully sure. But I increased it because we have here 64bit values. So to keep precision.
There was a problem hiding this comment.
This does not do what one might think. The calculation ist float, the float is then stored as double.
There was a problem hiding this comment.
you are right, I forgot to change also pow10_table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.