fsk: add Y option for selecting different fsk low pass coefficients #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merbanan
force-pushed
the
feat-new_fsk_pulse_detector
branch
from
bf2ddc0 to
d00f5d1
Compare
|
@zuckschwerdt this is as clean as I could make it. The -r sample file option will not work though. I think the file name parser needs to set frequency and sample rate cfg values to get it to work the same. |
|
Anyway the code works, there are some tiny changes before I can merge. I just want overall input of the approach. |
|
With this patch several decoders should be able to activate by default. |
|
Overall looks tidy enough. The |
Prepatory work for new fsk pulse detector
merbanan
force-pushed
the
feat-new_fsk_pulse_detector
branch
from
90f0800 to
03f8df8
Compare
|
Ok, the is now fairly useful. I'll merge it now and improve it later. |
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepatory work for new fsk pulse detector.
FSK demod low pass filter selection.