Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Catalog __repr__ to sorted set #94

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Conversation

MaxSchambach
Copy link
Contributor

Description

Change the representation of Catalog to a set of sources keys sorted alphabetically.

The sorted representation is case-insensitive. This way, looking up keys in a catalog becomes a little easier.

Fixes # issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

@AlirezaSohofi AlirezaSohofi requested review from pzdkn and removed request for AlirezaSohofi October 11, 2022 16:08
Copy link
Contributor

@pzdkn pzdkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaxSchambach MaxSchambach merged commit a2f566c into main Oct 19, 2022
@MaxSchambach MaxSchambach deleted the max-sort-catalog-repr branch October 19, 2022 12:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants