Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks to check backwards compatibility with py3.6+ #87

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

AlpAribal
Copy link
Contributor

@AlpAribal AlpAribal commented Sep 5, 2022

Description

Updates flake8 hook version and introduces two flake8-plugins to check for backwards-incompatible syntax.

  • flake8-walrus check for the usage of the walrus operator and warns if used
  • flake8-typing-imports checks for incompatible imports of the typing module

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

Copy link
Contributor

@AlirezaSohofi AlirezaSohofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👍

@AlpAribal AlpAribal merged commit fd75556 into main Sep 7, 2022
@AlpAribal AlpAribal deleted the alp-backwards-compat branch September 7, 2022 10:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants