Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiansu move leftover commits #32

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Tiansu move leftover commits #32

merged 2 commits into from
Apr 6, 2022

Conversation

TiansuYu
Copy link
Contributor

@TiansuYu TiansuYu commented Apr 6, 2022

Description

Move the leftover commits

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

AlpAribal and others added 2 commits April 6, 2022 14:47
@AlpAribal @TiansuYu
Update precommit hooks (#263)
b8821f7 
* run mx g PreCommit --overwrite

* lint repo

* patch bump

(cherry picked from commit f9123e59fd066d34731d0041019a973ca09de34d)
@TiansuYu
pin click and freeze
f9bc5f9
@TiansuYu TiansuYu requested a review from AlpAribal April 6, 2022 13:02
AlpAribal
AlpAribal approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@AlpAribal AlpAribal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@TiansuYu TiansuYu merged commit bd40bb0 into main Apr 6, 2022
@TiansuYu TiansuYu deleted the tiansu-move-leftover-commits branch April 6, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlpAribal AlpAribal AlpAribal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiansuYu @AlpAribal