Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readthedoc #29

Merged
merged 2 commits into from
Apr 5, 2022
Merged

fix readthedoc #29

merged 2 commits into from
Apr 5, 2022

Conversation

TiansuYu
Copy link
Contributor

@TiansuYu TiansuYu commented Apr 5, 2022

Description

The latest jinja2 release breaks the doc build, this fixes this.
The rendered doc can be seen from here: https://squirrel-core.readthedocs.io/en/tiansu-fix-readthedoc/ (This is hidden. Let me know your readthedocs account, then I can add you to see it)

Fixes # issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

requirements.in Outdated
@@ -8,5 +8,4 @@ random-name
ruamel.yaml
tqdm
numba
# typing-extensions<4,>=3.7.0 # required by apache-beam 2.35.0
# TODO resolution failure. Add this back once we have a functional main.
typing-extensions<4,>=3.7.0 # required by apache-beam 2.35.0
Copy link
Contributor

@AlpAribal AlpAribal Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just remove this, already about to be removed in internal repo (i.e. >=4 is fine).

@TiansuYu TiansuYu merged commit 1ec84c8 into main Apr 5, 2022
@TiansuYu TiansuYu deleted the tiansu-fix-readthedoc branch April 5, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants