Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create stale_prs.yml #106

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Create stale_prs.yml #106

merged 4 commits into from
Jan 19, 2023

Conversation

pzdkn
Copy link
Contributor

@pzdkn pzdkn commented Jan 17, 2023

Create Github Actions config to auto-label PR as stale after 30 days and auto-close after 7 days of been stale.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

@pzdkn
Copy link
Contributor Author

pzdkn commented Jan 17, 2023

added you @YmirKhang , as this is kind of ops-related.

YmirKhang
YmirKhang previously approved these changes Jan 19, 2023
Copy link

@YmirKhang YmirKhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


on:
schedule:
- cron: 21 18 * * *

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 18:21 a special time for squirrel?

Copy link
Contributor Author

@pzdkn pzdkn Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was suggested by github and couldn't edit it

pull-requests: write

steps:
- uses: actions/stale@v5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the latest release is v7. Do we have any reason to stick with v5 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was suggested by github too. Will update to newest

Create Github Actions config to auto-label PR as stale after 30 days and auto-close after 7 days of been stale.
Update stale version v5 => v7
@pzdkn pzdkn requested a review from YmirKhang January 19, 2023 10:47
@AlirezaSohofi AlirezaSohofi removed their request for review January 19, 2023 10:52
Copy link

@YmirKhang YmirKhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. LGTM!

@pzdkn pzdkn merged commit 084a13c into main Jan 19, 2023
@pzdkn pzdkn deleted the peng-close-stale-prs branch January 19, 2023 13:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants