Allow configuration of set_udub ril op #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some devices, like the Volla phone, the operation of set_udub to request whether the user is busy or not, produces a halt of the modem dropping any on going call if the operation happens, like rejecting a new incoming call while one is active. This patch allows to set the operation to a regular hangup. Signed-off-by: José Pekkarinen <[email protected]>
monich
requested changes
Nov 15, 2021
| # is busy through this function. This produces that, if you cancel an | ||
| # awaiting call because of an on going one, both calls will be hang up. | ||
| # | ||
| #rilRequestOnSetUdub=13 |
There was a problem hiding this comment.
AFAICT the default for RIL_REQUEST_UDUB is 17, please mention that in a way similar to how it's done for other entries.
| @@ -27,6 +27,7 @@ | |||
| #include "ril_vendor.h" | |||
| #include "ril_devmon.h" | |||
| #include "ril_log.h" | |||
| #include "ril-constants.h" | |||
There was a problem hiding this comment.
src/ril_plugin.c:30:10: fatal error: ril-constants.h: No such file or directory
#include "ril-constants.h"
^~~~~~~~~~~~~~~~~
compilation terminated.
I think you can just drop this line, this header must be included from elsewhere as <ofono/ril-constants.h>
| @@ -1806,6 +1811,14 @@ static RilSlot *ril_plugin_parse_config_group(GKeyFile *file, | |||
| group, config->cell_info_interval_long_ms); | |||
| } | |||
|
|
|||
| /* rilRequestOnSetUdub */ | |||
| if (ril_config_get_integer(file, group, | |||
There was a problem hiding this comment.
src/ril_plugin.c:1815:6: warning: implicit declaration of function 'ril_config_get_integer'; did you mean 'ril_config_get_ints'? [-Wimplicit-function-declaration]
if (ril_config_get_integer(file, group,
^~~~~~~~~~~~~~~~~~~~~~
Should be ofono_conf_get_integer()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some devices, like the Volla phone, the
operation of set_udub to request whether the
user is busy or not, produces a halt of the modem
dropping any on going call if the operation
happens, like rejecting a new incoming call
while one is active. This patch allows to
set the operation to a regular hangup.
Signed-off-by: José Pekkarinen [email protected]