Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add actions para projetcs #17

Merged
merged 18 commits into from
Jul 24, 2022
Merged

feat: add actions para projetcs #17

merged 18 commits into from
Jul 24, 2022

Conversation

EzzioMoreira
Copy link
Contributor

@EzzioMoreira EzzioMoreira commented Jun 7, 2022

Titulo

Adicionar automaticamente as issues a um projeto do GitHub. Observe que isso é para projetos do GitHub (beta), não para os projetos originais do GitHub.

Obs. Eu não consegui fazer o reuso do workflow, acho que por alguma limitação da actions. Sempre retorna o erro da secrets estou abrindo uma issue no projeto add-to-project, vou questinoar se alguém já conseguiu utilizar como actions reusable.

Link da issue: actions/add-to-project#160

  • Garanta que seu topic/feature/bugfix branch tenha uma branch nomeada e não a sua branch main esteja no PR
  • Dê um titulo que expresse o objetivo do PR
  • Associe seu PR a uma Issue criada no repositósito. Caso seja uma correção de linguagem ou pequenas correções, não é necessário
  • Descreva o objetivo do PR
  • Inclua links relevantes para a sua modificação/sugestão/correção
  • Descreva um passo-a-passo para testar o seu PR

Issue

Objetivo

Adicionar automaticamente as issues a um projeto do GitHub.

Referências

https://github.com/actions/add-to-project

Como testar

Copy link
Member

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bem legal @EzzioMoreira 🙂

Deixei alguns comentários de mudanças, qualquer dúvida é só perguntar.

.github/workflows/add_issues_projects.yaml Outdated Show resolved Hide resolved
.github/workflows/add_issues_projects.yaml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/add_issues_projects.md Outdated Show resolved Hide resolved
docs/add_issues_projects.md Outdated Show resolved Hide resolved
.github/workflows/adiciona_issues_project_mentoriaiac.yaml Outdated Show resolved Hide resolved
docs/add_issues_projects.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gomex gomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eu acho que está perfeito, só tem o detalhe de secret que podemos conversar na call de hoje.

.github/workflows/add_issues_projects.yaml Outdated Show resolved Hide resolved
.github/workflows/add_issues_projects.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@gomex gomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eu testei aqui: https://github.com/gomex/iac-modulo-aws-ecr/actions/runs/2686235483 e deu esse erro:

Invalid workflow file: .github/workflows/project.yaml#L9
error parsing called workflow "EzzioMoreira/cicd_centralizado/.github/workflows/add_issues_projects.yaml@feat/add-actions-projects": secret name `github_token` within `workflow_call` can not be used since it would collide with system reserved name

@gomex gomex merged commit 5d12164 into mentoriaiac:main Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants