Make readonly text translatable

mendixlabs · Jan 4, 2019 · 6ae9923 · 6ae9923
1 parent e60c594
commit 6ae9923
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/components/RichText.ts b/src/components/RichText.ts
@@ -59,7 +59,7 @@ export class RichText extends Component<RichTextProps> {
             {
                 className: classNames("widget-rich-text", this.props.className, {
                     "has-error": !!this.props.alertMessage,
-                    "notranslate": !this.props.translatable,
+                    "notranslate": !this.props.translatable || this.props.readOnlyStyle !== "text",
                     [ RichText.getReadOnlyClasses(this.props.readOnlyStyle) ]: this.props.readOnly,
                     "buttons-hidden": this.props.editorOption === "custom" && this.props.customOptions.length === 0,
                     "ql-snow": this.props.readOnly && this.props.readOnlyStyle === "text"

diff --git a/src/components/RichTextContainer.ts b/src/components/RichTextContainer.ts
@@ -70,7 +70,7 @@ export default class RichTextContainer extends Component<RichTextContainerProps,
                 className: this.props.class,
                 style: parseStyle(this.props.style),
                 sanitizeContent: this.props.sanitizeContent,
-                translatable: this.props.editable === "never",
+                translatable: this.props.editable === "never" || this.props.readOnly,
                 value: this.state.value,
                 onChange: !readOnly ? this.handleOnChange : undefined,
                 onBlur: !readOnly ? this.executeOnChangeAction : undefined,

diff --git a/src/components/__tests__/RichText.spec.ts b/src/components/__tests__/RichText.spec.ts
@@ -75,7 +75,7 @@ describe("RichText", () => {
 
             textEditor = shallowRenderTextEditor(richTextProps);
             expect(textEditor).toBeElement(
-                createElement("div", { className: "widget-rich-text has-error" },
+                createElement("div", { className: "widget-rich-text notranslate has-error" },
                     createElement("div", {
                             style: { whiteSpace: "pre-wrap" },
                             dangerouslySetInnerHTML: undefined

diff --git a/src/package.xml b/src/package.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <package xmlns="http://www.mendix.com/package/1.0/">
-    <clientModule name="RichText" version="1.3.0" xmlns="http://www.mendix.com/clientModule/1.0/">
+    <clientModule name="RichText" version="1.3.1" xmlns="http://www.mendix.com/clientModule/1.0/">
         <widgetFiles>
             <widgetFile path="RichText.xml"/>
         </widgetFiles>