Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new header support origin trial #682

Closed
wants to merge 6 commits into from
Closed

Added new header support origin trial #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a50fecb
Added new header support origin trial
SwapnilThange Oct 23, 2023
6e0335e
added test cases for new header
SwapnilThange Oct 23, 2023
0a6db40
corrected alignment
SwapnilThange Oct 23, 2023
92a4649
Updated spellings
SwapnilThange Oct 23, 2023
ee62e7c
updated test cases
SwapnilThange Oct 23, 2023
5515eff
updated tests
SwapnilThange Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions buildpack/core/nginx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"Strict-Transport-Security": r"(?i)(^max-age=[0-9]*$|^max-age=[0-9]*; includeSubDomains$|^max-age=[0-9]*; preload$)", # noqa: line-too-long
"X-Permitted-Cross-Domain-Policies": r"(?i)(^all$|^none$|^master-only$|^by-content-type$|^by-ftp-filename$)", # noqa: line-too-long
"X-XSS-Protection": r"(?i)(^0$|^1$|^1; mode=block$|^1; report=https?://([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9])(\.([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]{0,61}[a-zA-Z0-9]))*(:\d+)?$)", # noqa: line-too-long
"Origin-Trial": r"[a-zA-Z0-9:;/''\"\*_\- \.\n?=%&+]+",
}

CONFIG_FILE = "nginx/conf/nginx.conf"
Expand Down
22 changes: 22 additions & 0 deletions tests/unit/test_custom_headers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,3 +170,25 @@ def test_invalid_header_json(self):
os.environ["HTTP_RESPONSE_HEADERS"] = "invalid"
with self.assertRaises(ValueError):
nginx._get_http_headers()

def test_valid_header_originTrial(self):
os.environ["HTTP_RESPONSE_HEADERS"] = json.dumps(
{
"Origin-Trial": "ArmVE2nkyn2sDf+DNN9MJVBYCagx:+NCFIc7=="
}
)
header_config = nginx._get_http_headers()
self.assertIn(
("Origin-Trial",
"ArmVE2nkyn2sDf+DNN9MJVBYCagx:+NCFIc7==",
),
header_config,
)
def test_inValid_header_originTrial(self):
os.environ["HTTP_RESPONSE_HEADERS"] = json.dumps(
{
"Origin-Trial": "#####"
}
)
header_config = nginx._get_http_headers()
self.assertEqual([], header_config)
Loading