-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Datadog integration #385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbastiaans
force-pushed
the
develop
branch
from
December 17, 2020 09:33
a140603
to
7df5585
Compare
markbastiaans
force-pushed
the
datadog_integration_improvements
branch
5 times, most recently
from
December 18, 2020 15:51
a7c61e3
to
883498b
Compare
serg-firsov
approved these changes
Dec 18, 2020
abhishekamte-mx
force-pushed
the
datadog_integration_improvements
branch
from
December 21, 2020 08:04
b3ec70a
to
2415a96
Compare
markbastiaans
commented
Dec 24, 2020
markbastiaans
force-pushed
the
datadog_integration_improvements
branch
3 times, most recently
from
January 7, 2021 10:40
a8b9911
to
5431cfb
Compare
markbastiaans
force-pushed
the
datadog_integration_improvements
branch
4 times, most recently
from
January 13, 2021 13:04
5add5e6
to
3b4f9d1
Compare
markbastiaans
force-pushed
the
datadog_integration_improvements
branch
3 times, most recently
from
January 14, 2021 14:59
b29e1c1
to
60b504a
Compare
markbastiaans
requested review from
matyaskuti and
serg-firsov
and removed request for
cwesdorp
January 14, 2021 15:02
markbastiaans
force-pushed
the
datadog_integration_improvements
branch
3 times, most recently
from
January 15, 2021 13:44
5ac2251
to
2ea7f47
Compare
markbastiaans
force-pushed
the
datadog_integration_improvements
branch
2 times, most recently
from
January 28, 2021 11:46
02165d8
to
cfd8cb5
Compare
markbastiaans
force-pushed
the
datadog_integration_improvements
branch
3 times, most recently
from
January 28, 2021 14:08
db4f75d
to
420c6db
Compare
markbastiaans
force-pushed
the
datadog_integration_improvements
branch
4 times, most recently
from
February 11, 2021 13:34
d283e0a
to
1c9e101
Compare
matyaskuti
reviewed
Feb 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay in general, a few small comments and questions, nothing big related to the overall goal.
matyaskuti
approved these changes
Feb 15, 2021
markbastiaans
force-pushed
the
datadog_integration_improvements
branch
from
February 15, 2021 10:22
9e7da3d
to
4c25af7
Compare
markbastiaans
force-pushed
the
datadog_integration_improvements
branch
from
February 15, 2021 10:36
4c25af7
to
7596b30
Compare
markbastiaans
added a commit
that referenced
this pull request
Feb 22, 2021
* Improved Datadog integration * Move loggregator util function to metrics module * Update Python dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes to the Datadog and Telegraf integrations:
DATADOG_LOGS_REDACTION
environment variable tofalse
.Known Limitations
Telegraf does not support (Datadog) metric types correctly yet (e.g. rate, counter, gauge). This means that all database metrics are currently pushed to Datadog as a gauge.
The most important metrics (
before_xid_wraparound
,connections
,database_size
,db.count
,locks
,max_connections
,percent_usage_connections
,table.count
,deadlocks
) are gauges and are compatible with the Datadog PostgreSQL integration and associated dashboards.If you do require the additional rate and counter metrics, there is a workaround available. First, set the
DATADOG_DATABASE_RATE_COUNT_METRICS
environment variable totrue
. After that variable is enabled, the rate and counter metrics are suffixed by either_count
or_rate
to prevent collisions with the official Datadog metrics. In the Datadog UI, the metric type and unit can be changed to reflect this. We also set a helpfulinterval
tag (10s
) which can be used here. Additionally, gauge metrics can be rolled up in Datadog dashboards. The correct type and unit for other submitted metrics can be found here.