Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comparison issue that breaks platform hooks #709

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebSa
Copy link

@SebSa SebSa commented Oct 31, 2024

fix: comparison issue that breaks platform hooks

A type comparison issue in line 19 the platform_modify function on the latest 64 bit changes yields:

2024-10-31 13:22:38 [INFO] [mender-convert-modify] Running hook: platform_modify
configs/raspberrypi_64_config: line 19: [: debian: integer expression expected

have fixed that with a suggestion from @danielskinstad

Changelog: None
Ticket: None

@SebSa SebSa force-pushed the fix-platform-hooks branch 2 times, most recently from 40c0f34 to ba46a7b Compare October 31, 2024 22:44
Copy link
Contributor

@danielskinstad danielskinstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution!

Please take a look at this: https://github.com/mendersoftware/mendertesting/blob/master/commitlint/grammar.md

A fix requires a changelog and a ticket (can be set to none).

See comment below.

configs/raspberrypi_64_config Outdated Show resolved Hide resolved
@SebSa SebSa changed the title fix typo that breaks platform hooks fix something that breaks platform hooks Nov 1, 2024
@SebSa SebSa changed the title fix something that breaks platform hooks fix comparison issue that breaks platform hooks Nov 1, 2024
@danielskinstad
Copy link
Contributor

The current pipeline will fail because the commit is not signed off.

Commit 19ed07227f1132071542ef92db6e1e50ddbc2a85 is not signed off! Use --signoff with your commit. Make sure that the Author of the commit matches the one in Signed-off-by

@danielskinstad
Copy link
Contributor

Thanks a lot, it looks good

I just saw that we have the same issue in raspberrypi_config as well, I'll be happy to co-author the commit and add it myself, but you can also do it if you want :)

changelog: None
ticket: None
Signed-off-by: SebSa <[email protected]>
@SebSa
Copy link
Author

SebSa commented Nov 6, 2024

Thanks a lot, it looks good

I just saw that we have the same issue in raspberrypi_config as well, I'll be happy to co-author the commit and add it myself, but you can also do it if you want :)

I've added this now, is there anything else I need to do?

@danielskinstad
Copy link
Contributor

I've added this now, is there anything else I need to do?

Thanks for adding it! Can you rebase it on top of master?
The only thing is the commit; while you're rebasing, could you also change the title to something like
fix: correctly check that RASPBERRYPI_OS_REQUIRED_ID is set
and set
Changelog: Title
so we create a changelog entry for this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants