-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix comparison issue that breaks platform hooks #709
base: master
Are you sure you want to change the base?
Conversation
40c0f34
to
ba46a7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for your contribution!
Please take a look at this: https://github.com/mendersoftware/mendertesting/blob/master/commitlint/grammar.md
A fix requires a changelog and a ticket (can be set to none).
See comment below.
16c56c0
to
19ed072
Compare
The current pipeline will fail because the commit is not signed off.
|
19ed072
to
42b77d1
Compare
Thanks a lot, it looks good I just saw that we have the same issue in |
changelog: None ticket: None Signed-off-by: SebSa <[email protected]>
42b77d1
to
e8534d3
Compare
I've added this now, is there anything else I need to do? |
Thanks for adding it! Can you rebase it on top of master? |
fix: comparison issue that breaks platform hooks
A type comparison issue in line 19 the platform_modify function on the latest 64 bit changes yields:
have fixed that with a suggestion from @danielskinstad
Changelog: None
Ticket: None