-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mempool chart filtering. #847
Add mempool chart filtering. #847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be moved into a drop-down box, using the "filter" button like how the bisq.markets transactions table can be filtered - we don't want to lose that nice full-width chart that you just made :)
c50f428
to
587f19a
Compare
Hey @wiz ! I've changed the filtering to a dropdown menu, similar to bisq.markets transactions. Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frontend/src/app/components/television/television.component.html
Outdated
Show resolved
Hide resolved
@wiz @softsimon as you suggested: Tasks
Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but when comparing it to the previous functionality I noticed you're filtering it the wrong way, i.e. we want to filter fee rate tiers below the selected value, not above it. For comparison, please see https://mempool.bitcoin.ninja/graphs which is running the old chart library and click on a middle fee rate tier and you'll see what I mean.
Revert left margin from tv page. Change text dropdown filter to icon. Change dropdown inactive item color. Revert 500 limit rate.
86ace78
to
91a83d3
Compare
Fix order of active and inactive fee ranges.
91a83d3
to
a43cd48
Compare
Tasks
Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK @ a43cd48
Looks good and works well
Fix #834 .
Preview