Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mempool chart filtering. #847

Merged
merged 5 commits into from
Oct 8, 2021

Conversation

MiguelMedeiros
Copy link
Contributor

Fix #834 .

Preview

filtering3

@MiguelMedeiros MiguelMedeiros added this to the v2.3.0 milestone Oct 1, 2021
Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be moved into a drop-down box, using the "filter" button like how the bisq.markets transactions table can be filtered - we don't want to lose that nice full-width chart that you just made :)

@MiguelMedeiros MiguelMedeiros force-pushed the add-filtering-mempool-charts branch from c50f428 to 587f19a Compare October 6, 2021 04:09
@MiguelMedeiros MiguelMedeiros requested a review from wiz October 6, 2021 04:09
@MiguelMedeiros
Copy link
Contributor Author

I think this should be moved into a drop-down box, using the "filter" button like how the bisq.markets transactions table can be filtered - we don't want to lose that nice full-width chart that you just made :)

Hey @wiz ! I've changed the filtering to a dropdown menu, similar to bisq.markets transactions.

Preview

filtering-dropdown

Copy link
Member

@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

  1. Replace the "Fees Range" button text with a filter icon

Screen Shot 2021-10-06 at 11 39 46

  1. Clicking a second time on the dropdown should close it

Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miguel, this PR should not hide fee rate tiers above 200 sats/vB - we've discussed this many times already.

Before:
Screen Shot 2021-10-06 at 17 03 19

After:
Screen Shot 2021-10-06 at 17 03 33

@MiguelMedeiros
Copy link
Contributor Author

@wiz @softsimon as you suggested:

Tasks

  • Add toggle button to dropdown menu.
  • Revert left margin from tv page.
  • Change text dropdown filter to icon.
  • Change dropdown inactive item color.
  • Revert 500 limit rate.

Preview

filter-done

Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but when comparing it to the previous functionality I noticed you're filtering it the wrong way, i.e. we want to filter fee rate tiers below the selected value, not above it. For comparison, please see https://mempool.bitcoin.ninja/graphs which is running the old chart library and click on a middle fee rate tier and you'll see what I mean.

Revert left margin from tv page.
Change text dropdown filter to icon.
Change dropdown inactive item color.
Revert 500 limit rate.
@MiguelMedeiros MiguelMedeiros force-pushed the add-filtering-mempool-charts branch from 86ace78 to 91a83d3 Compare October 7, 2021 19:00
Fix order of active and inactive fee ranges.
@MiguelMedeiros MiguelMedeiros force-pushed the add-filtering-mempool-charts branch from 91a83d3 to a43cd48 Compare October 7, 2021 19:03
@MiguelMedeiros
Copy link
Contributor Author

@wiz

Tasks

  • Remove unnecessary code to controle legends.
  • Fix order of active and inactive fee ranges.

Preview

filter-done-1

@MiguelMedeiros MiguelMedeiros requested a review from wiz October 7, 2021 19:04
Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ a43cd48
Looks good and works well

@wiz wiz merged commit bf563cc into mempool:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart filtering
3 participants