Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ony consider channel stats = 1 for stats calculation #2202

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

nymkappa
Copy link
Member

@nymkappa nymkappa commented Jul 27, 2022

Fixes #2199

When we run any kind of calculation using channels (capacity, channel count, and other things), we should only consider active channels (channel.status = 1).

@nymkappa nymkappa requested review from wiz and softsimon July 27, 2022 14:20
@cla-bot cla-bot bot added the cla-signed label Jul 27, 2022
@nymkappa nymkappa changed the title [LN stats] Ony consider channel stats = 1 for stats calculation Ony consider channel stats = 1 for stats calculation Jul 27, 2022
Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ v2.5.0-dev [d6e9500b]

@wiz wiz merged commit 88648da into master Jul 27, 2022
@wiz wiz deleted the nymkappa/bugfix/only-user-active-channel-for-stats branch July 27, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure channels stats are only computed on active channels (status = 1)
2 participants