Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Liquid Testnet as frontend option #1052

Merged
merged 8 commits into from
Dec 29, 2021
Merged

Adding Liquid Testnet as frontend option #1052

merged 8 commits into from
Dec 29, 2021

Conversation

softsimon
Copy link
Member

@softsimon softsimon commented Dec 27, 2021 •
edited
Loading

fixes #97

  • hide liquid bitcoin on assets page for testnet
  • download assets.json files to /testnet/resources or something
  • replace incoming transactions chart, instead of L-BTC in circulation
  • click about -> home shows purple blocks
  • Native asset page is broken
  • Native asset page is pushing random new transactions as related to the asset
  • Search field resorts to liquid mainnet /

Screen Shot 2021-12-28 at 00 35 11

@softsimon softsimon requested a review from wiz December 27, 2021 18:55
@softsimon softsimon force-pushed the simon/liquid-testnet branch 3 times, most recently from 5876ccf to 76c4c9a Compare December 28, 2021 07:02
@softsimon softsimon force-pushed the simon/liquid-testnet branch from 76c4c9a to fd34761 Compare December 28, 2021 07:16
@softsimon
Copy link
Member Author

softsimon commented Dec 28, 2021 •
edited
Loading

Set the Liquid Testnet backend network config to "liquidtestnet"

@softsimon softsimon force-pushed the simon/liquid-testnet branch from a7b5d02 to 504f46c Compare December 28, 2021 20:41
wiz
wiz approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ a48c2c0
Works well enough to ship for now, minor issues can be fixed in subsequent PRs

@wiz wiz merged commit 7ce1cc5 into master Dec 29, 2021
@wiz wiz deleted the simon/liquid-testnet branch December 29, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address page: Separate confirmed and unconfirmed balance
2 participants
@softsimon @wiz