Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable mempool txs page size #65

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

mononaut
Copy link
Contributor

This PR makes the paginated /internal/mempool/txs/last_txid endpoint match the other paginated tx APIs by accepting a max_txs query parameter.

If the max_txs parameter is not supplied, the endpoint returns a default number of transactions, which is now configurable via a new command line argument --rest_max_mempool_page_size.

src/config.rs Outdated Show resolved Hide resolved
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mononaut mononaut force-pushed the mononaut/mempool-txs-page-size branch from 6546c6c to 168862b Compare November 15, 2023 07:10
Copy link
Member

@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK @ [168862b]

@softsimon softsimon merged commit a13c7c3 into mempool Nov 15, 2023
7 checks passed
@softsimon softsimon deleted the mononaut/mempool-txs-page-size branch November 15, 2023 07:39
SatoKentaNayoro pushed a commit to boolnetwork/mempool-electrs that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants