Feature: Install popular-scripts as a cronjob #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junderw
force-pushed
the
junderw/start-script-fix
branch
from
3e348be to
3ce7053
Compare
junderw
force-pushed
the
junderw/start-script-fix
branch
from
3ce7053 to
a8aba23
Compare
wiz
reviewed
Dec 13, 2024
wiz
approved these changes
Dec 13, 2024
junderw
commented
Dec 13, 2024
| if [ ! -e "${POPULAR_SCRIPTS_FILE}" ];then | ||
| generate_popular_scripts | ||
| fi | ||
| # if [ ! -e "${POPULAR_SCRIPTS_FILE}" ];then |
There was a problem hiding this comment.
I think you commented out the wrong thing.
You left the "add crontab" if block
But commented out the "perform popular_scripts job" if block
If you run this, it will add the cron job but not run the actual job when the file is missing, and the electrs run command will fail when it tries to run the cache operations on a file that doesn't exist.
There was a problem hiding this comment.
Also, switching the if block you comment out will change the behavior from
"Always run the popular_script job before running electrs" (current)
to
"Only run the popular_script job when the file doesn't exist. Otherwise, the cron job should have kept the file up to date for us so we shouldn't need to run it" (This PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
I am shell noob, be kind.