(Requires merge by @wiz) Feat: Unix sockets for Electrum RPC #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junderw
force-pushed
the
junderw/http-socket-electrum
branch
from
4205fd1 to
1043fd2
Compare
mononaut
previously approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Tested ACK @ 1043fd2a
Nothing seems to break in TCP mode.
I tested the new unix socket RPC mode by relaying TCP requests through socat:
socat TCP-LISTEN:50001,fork UNIX-CONNECT:/tmp/esplora-bitcoin-mainnet-rpc
and it handled both the pummeller test and regular wallet requests successfully.
junderw
force-pushed
the
junderw/http-socket-electrum
branch
from
1043fd2 to
4ad4001
Compare
junderw
dismissed
mononaut’s stale review
Refactored, please re-test. Thanks
|
I tested TCP and Unix versions and they still work post-refactor. Self tested ACK 4ad40012d0f9723220af50f08cab2280c5f94d32 using mononaut's Unix forwarding with socat. |
junderw
force-pushed
the
junderw/http-socket-electrum
branch
from
4ad4001 to
941cae1
Compare
|
Self tested ACK 941cae186adc145011c89c35d83c2bb121c4715a (The changes since the last ACK are all just startup scripts) |
junderw
changed the title
junderw
force-pushed
the
junderw/http-socket-electrum
branch
from
941cae1 to
8c5cd7e
Compare
wiz
approved these changes
Sep 30, 2023
junderw
force-pushed
the
junderw/http-socket-electrum
branch
from
8c5cd7e to
4339a51
Compare
wiz
approved these changes
Oct 3, 2023
SatoKentaNayoro
pushed a commit
to boolnetwork/mempool-electrs
that referenced
this pull request
Nov 29, 2024
(Requires merge by @wiz) Feat: Unix sockets for Electrum RPC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Since this PR changes fundamentally how ops works, only @wiz should merge it. The timing of this merge is important, and only @wiz should control it.
The Rust library doesn't support Unix socket connections, so I was unable to test it... however, I was able to confirm that the Tcp code hasn't broken. (No leaked threads or sockets)
Note:
When
"electrum-discovery"feature is enabled, originally the add_peer request would upgrade a client to a peer by looking at their TcpStream's IpAddr... with UnixStream we have no IpAddr, so I just respond with an error saying that "sorry we couldn't add you as a peer because...... reasons."