-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase performance for precache operation #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junderw
force-pushed
the
junderw/perf-precache-speed
branch
from
September 18, 2023 23:56
c2b6f81
to
8332760
Compare
junderw
changed the title
WIP: Increase performance for precache operation
Increase performance for precache operation
Sep 18, 2023
junderw
force-pushed
the
junderw/perf-precache-speed
branch
2 times, most recently
from
September 19, 2023 02:12
53b46cc
to
d5d2573
Compare
I rebased on top of #44 since we really need to merge that before this. |
junderw
force-pushed
the
junderw/perf-precache-speed
branch
from
September 19, 2023 03:47
d5d2573
to
811c6c4
Compare
|
wiz
force-pushed
the
junderw/perf-precache-speed
branch
from
October 3, 2023 04:21
9c261eb
to
69c97c1
Compare
wiz
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK @ d49f752
SatoKentaNayoro
pushed a commit
to boolnetwork/mempool-electrs
that referenced
this pull request
Nov 29, 2024
Increase performance for precache operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flushing after every call is slow.
How slow?
Extremely slow. The performance (highly dependent on the physical media the disk uses) on my 5000MB/s NVMe SSD is about 2x.
Cuts the time to precache in half.
I took this opportunity to re-activate the UtxoCache caching.
Also, we should generate the popular scripts txt on each startup in prod. And I moved the precache into the background so the server can still serve requests.
TODO: