Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect internal apis #38

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Protect internal apis #38

merged 3 commits into from
Nov 12, 2023

Conversation

mononaut
Copy link
Contributor

@mononaut mononaut commented Aug 16, 2023

Companion PR to mempool/mempool#4158.

Adds an /internal/ prefix to the following expensive bulk API endpoints.

src/rest.rs Outdated Show resolved Hide resolved
Copy link
Member

@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK @ [50c9a9f8]

But depends on the (currently draft) PR mempool/mempool#4158

@mononaut mononaut force-pushed the mononaut/protect-internal-apis branch from e8cf124 to 281b699 Compare November 12, 2023 05:13
@mononaut
Copy link
Contributor Author

rebased on current master [649f28d]

Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ mempool-electrs 3.0.0-dev-281b699

@wiz wiz merged commit e28f887 into mempool Nov 12, 2023
7 checks passed
@wiz wiz deleted the mononaut/protect-internal-apis branch November 12, 2023 08:40
SatoKentaNayoro pushed a commit to boolnetwork/mempool-electrs that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants