Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submitpackage endpoint #105

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Add submitpackage endpoint #105

merged 1 commit into from
Nov 1, 2024

Conversation

natsoni
Copy link
Contributor

@natsoni natsoni commented Oct 13, 2024

This PR adds a new REST endpoint POST /txs/package, which is very similar to POST /txs/test added in #81.

Review very carefully since I'm not familiar with rust at all

@natsoni natsoni force-pushed the natsoni/submitpackage-rpc branch from 1e5cc67 to 6da98e8 Compare October 13, 2024 03:05
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Most fixes are tiny.

src/daemon.rs Outdated Show resolved Hide resolved
src/daemon.rs Outdated Show resolved Hide resolved
src/daemon.rs Outdated Show resolved Hide resolved
@natsoni natsoni force-pushed the natsoni/submitpackage-rpc branch from 6da98e8 to 9f87c8f Compare October 15, 2024 14:43
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9f87c8f

@wiz wiz merged commit cb79811 into mempool Nov 1, 2024
7 checks passed
@wiz wiz deleted the natsoni/submitpackage-rpc branch November 1, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants