Poststats #9
Open
Poststats #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memory-thrasher
requested changes
Dec 28, 2022
DB/dbo/PostStatsView.sql
Outdated
| with cte_Users as (select Username from Users) | ||
| ,cte_Email as (select username, Email from users) | ||
| ,cte_First_post as (select authorusername, min(CreatedAt) First_Post from articles group by AuthorUsername) | ||
| ,cte_Last_Post as (select authorusername, max(CreatedAt) Last_Post from articles group by authorusername) |
There was a problem hiding this comment.
First_post and Last_post can be the same cte bc they pull from the same table
There was a problem hiding this comment.
also article_count and distinct_articles
DB/dbo/PostStatsView.sql
Outdated
| ,cte_First_post as (select authorusername, min(CreatedAt) First_Post from articles group by AuthorUsername) | ||
| ,cte_Last_Post as (select authorusername, max(CreatedAt) Last_Post from articles group by authorusername) | ||
| ,cte_Article_Count as (select authorusername, count(id) Article_Count from Articles group by authorusername) | ||
| ,cte_Distinct_Articles as (select authorusername, count(body)-count(distinct body) Distinct_Articles from Articles group by authorusername) |
DB/dbo/PostStatsView.sql
Outdated
| ,cte_First_Comment as (select username, min(createdat) First_Comment from comments group by username) | ||
| ,cte_Last_Comment as (select username, max(createdat) Last_Comment from Comments group by username) | ||
| ,cte_Comment_Count as (select username, count(body) Comment_Count from Comments group by username) | ||
| ,cte_Deleted_Comments as (select username, count(DeletedAt) Deleted_Comments from comments group by username) |
There was a problem hiding this comment.
4 ctes that pull only from comments can be 1
DB/dbo/PostStatsView.sql
Outdated
| ,cte_Comment_Count as (select username, count(body) Comment_Count from Comments group by username) | ||
| ,cte_Deleted_Comments as (select username, count(DeletedAt) Deleted_Comments from comments group by username) | ||
| ,cte_Comments_Own_Post as (select comments.username, count(comments.Username) Comments_Own_Post from Comments | ||
| join articles on comments.ArticleId=articles.id where comments.username=articles.authorusername group by username) |
There was a problem hiding this comment.
Move select to a new line, indented. indent join so it lines up with its select. Put the where and group by both on their own lines with the same indent.
DB/dbo/PostStatsView.sql
Outdated
| ,cte_Deleted_Comments as (select username, count(DeletedAt) Deleted_Comments from comments group by username) | ||
| ,cte_Comments_Own_Post as (select comments.username, count(comments.Username) Comments_Own_Post from Comments | ||
| join articles on comments.ArticleId=articles.id where comments.username=articles.authorusername group by username) | ||
| select users.username, cte_email.Email, cte_first_post.First_Post, cte_Last_Post.Last_Post, cte_Article_Count.Article_Count, cte_Distinct_Articles.Distinct_Articles, cte_First_Comment.First_Comment, cte_Last_Comment.Last_Comment, cte_Comment_Count.Comment_Count, cte_Deleted_Comments.Deleted_Comments, cte_Comments_Own_Post.Comments_Own_Post from Users |
There was a problem hiding this comment.
put from on its own line and add an alias
DB/dbo/PostStatsView.sql
Outdated
| ,cte_Comments_Own_Post as (select comments.username, count(comments.Username) Comments_Own_Post from Comments | ||
| join articles on comments.ArticleId=articles.id where comments.username=articles.authorusername group by username) | ||
| select users.username, cte_email.Email, cte_first_post.First_Post, cte_Last_Post.Last_Post, cte_Article_Count.Article_Count, cte_Distinct_Articles.Distinct_Articles, cte_First_Comment.First_Comment, cte_Last_Comment.Last_Comment, cte_Comment_Count.Comment_Count, cte_Deleted_Comments.Deleted_Comments, cte_Comments_Own_Post.Comments_Own_Post from Users | ||
| left join cte_Email on cte_email.username=users.username |
There was a problem hiding this comment.
all these joins should have aliases
memory-thrasher
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.