Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main < E-util] Merge util module(single function) to main #311

Merged
merged 39 commits into from
Sep 5, 2023

Conversation

mpintaric55334
Copy link
Contributor

Description

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@mpintaric55334 mpintaric55334 added the status: ready PR is ready for review label Aug 10, 2023
@mpintaric55334 mpintaric55334 self-assigned this Aug 10, 2023
@mpintaric55334
Copy link
Contributor Author

@antoniofilipovic just a note, this is the one where we included memgraph submodule for tests to pass

Copy link
Contributor

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Aug 11, 2023
@mpintaric55334
Copy link
Contributor Author

THis cant be merged before ToString is approved on memgraph

@antoniofilipovic antoniofilipovic merged commit 26d6018 into main Sep 5, 2023
4 checks passed
@antoniofilipovic antoniofilipovic deleted the E-add-util-functions branch September 5, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants