Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom SSL for Lab configuration page #1030

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

AlexIchenskiy
Copy link
Contributor

@AlexIchenskiy AlexIchenskiy commented Nov 5, 2024

Description

This PR adds a page on adding custom SSL certificates to Memgraph Lab, along with new environment variables to the Install and connect page.

Pull request type

Please check what kind of PR this is:

  • Fix or improvement of an existing page
  • New documentation page, release related

Related PRs and issues

PR this doc page is related to:
memgraph/lab#913

Checklist:

  • Make sure all relevant tech details are documented
    • Update reference pages (e.g. clauses, functions, flags, experimental, monitoring)
    • Search for the feature you are working on (mentions) and make updates if needed
    • Provide a basic example of usage
    • In case your feature is an Enterprise one, list it under ME page and mark its page with Enterprise (example).
  • Check all content with Grammarly
  • Perform a self-review of my code
  • The build passes locally
  • My changes generate no new warnings or errors
  • Add a corresponding label
  • If release-related, add a product and version label
  • If release-related, add release note on product PR

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:43am

Copy link
Contributor

@katarinasupe katarinasupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great. I just pushed minor changes. General comment: we don't use title case for section titles.

Since this is related to the release, I rebased it.

@katarinasupe katarinasupe merged commit 102d8f1 into memgraph-2-21 Nov 5, 2024
2 checks passed
@katarinasupe katarinasupe deleted the add-custom-ssl-page branch November 5, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lab docs status: ready PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants