fix(fota): remove custom download callback #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary Since removing the custom retry logic from our OTA hack, we no longer need to use a custom download callback. This change removes the custom download callback and uses the default download callback provided by the Memfault SDK. ### Test Plan Triggered a FOTA update from a thingy91 device and confirmed that the FOTA worked successfully. --- Resolves: MCU-310
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
noahp
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since removing the custom retry logic from our OTA hack, we no longer
need to use a custom download callback. This change removes the custom
download callback and uses the default download callback provided by
the Memfault SDK.
Test Plan
Triggered a FOTA update from a thingy91 device and confirmed that the
FOTA worked successfully.
Resolves: MCU-306