Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fota): remove custom download callback #42

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

gminn
Copy link
Member

@gminn gminn commented Mar 26, 2024

Summary

Since removing the custom retry logic from our OTA hack, we no longer
need to use a custom download callback. This change removes the custom
download callback and uses the default download callback provided by
the Memfault SDK.

Test Plan

Triggered a FOTA update from a thingy91 device and confirmed that the
FOTA worked successfully.


Resolves: MCU-306

 ### Summary

 Since removing the custom retry logic from our OTA hack, we no longer
 need to use a custom download callback. This change removes the custom
 download callback and uses the default download callback provided by
 the Memfault SDK.

 ### Test Plan

 Triggered a FOTA update from a thingy91 device and confirmed that the
 FOTA worked successfully.

---

Resolves: MCU-310
Copy link
Member Author

gminn commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gminn and the rest of your teammates on Graphite Graphite

@gminn gminn requested a review from a team March 26, 2024 20:18
Copy link
Contributor

@noahp noahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! apologies for the slow review 😮‍💨

@gminn gminn merged commit 43d046f into main Apr 16, 2024
4 checks passed
@gminn gminn deleted the gminn/remove-fota-download-callback branch April 16, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants