-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: WSL2 for Firmware Development #517
base: master
Are you sure you want to change the base?
feat: WSL2 for Firmware Development #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JPHutchins Thank you for this second article! I like how practical and straighforward it is. I have a few comments below but I have one main one: I understand this comes from your own walk-through tutorial, but I'm curious if you'd be open to writing it more in the style of a blog post, where you narrate each section explaining the goal of each step, and maybe some experiences you had landing on this particular approach. Lmk what you think!
# This is a template for Interrupt posts. Use previous, more recent posts from the _posts/ | ||
# directory for more inspiration and patterns. | ||
# | ||
# When submitting a post for publishing, submit a PR with the post in the _drafts/ directory | ||
# and it will be moved to _posts/ on the date of publish. | ||
# | ||
# e.g. | ||
# $ cp _drafts/_template.md _drafts/my_post.md | ||
# | ||
# It will now show up in the front page when running Jekyll locally. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed
This tutorial is a living document maintained by | ||
Intercreate and we would welcome feedback and contributions at | ||
[GitHub](https://github.com/intercreate/docs/blob/main/Windows/wsl2.md)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this stand out more:
This tutorial is a living document maintained by | |
Intercreate and we would welcome feedback and contributions at | |
[GitHub](https://github.com/intercreate/docs/blob/main/Windows/wsl2.md)! | |
> This tutorial is a living document maintained by | |
> Intercreate and we would welcome feedback and contributions at | |
> [GitHub](https://github.com/intercreate/docs/blob/main/Windows/wsl2.md)! |
Intercreate and we would welcome feedback and contributions at | ||
[GitHub](https://github.com/intercreate/docs/blob/main/Windows/wsl2.md)! | ||
|
||
Contributions by Michael Brust, Alden Haase, JP Hutchins, and Ishani Raha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you feel strongly about it, let's move this to the end and put it in italics
|
||
Each task in this section is run from within the Windows 11 environment. | ||
|
||
### Windows 11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this extra section header isn't necessary - what do you think of combining the paragraph below with the sentence above?
Windows Update until up to date. | ||
|
||
[Installation Documentation](https://support.microsoft.com/en-us/windows/ways-to-install-windows-11-e0edbbfb-cfc5-4011-868b-2ce77ac7c70e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows Update until up to date. | |
[Installation Documentation](https://support.microsoft.com/en-us/windows/ways-to-install-windows-11-e0edbbfb-cfc5-4011-868b-2ce77ac7c70e) | |
Windows Update until up to date. See the official [installation documentation](https://support.microsoft.com/en-us/windows/ways-to-install-windows-11-e0edbbfb-cfc5-4011-868b-2ce77ac7c70e) provided by windows to install Windows 11. |
> setting up a [Nerd Font](https://www.nerdfonts.com/) like FiraCode, | ||
> configuring [Oh My Posh](https://ohmyposh.dev/), etc. | ||
|
||
[Installation Documentation](https://github.com/microsoft/terminal#installing-and-running-windows-terminal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest moving this into the section where you give the powershell command, and embed it into a sentence
> | ||
> Make sure that "Virtual Machine Platform" is checked. | ||
|
||
[Installation Documentation](https://learn.microsoft.com/en-us/windows/wsl/install) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here on embedding into a sentance
Original PR here: #515
This PR assumes that #516 has been merged.
This part of the previous article should be updated to link to this article instead of GitHub: https://github.com/intercreate/interrupt/blob/795a1678485adfd1a07d82e0fa73282ecea0144f/_drafts/wsl2-as-a-firmware-development-environment.md?plain=1#L476-L480
JP