Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hash to reference newly uploaded binaries #64

Merged

Conversation

dsubak
Copy link
Contributor

@dsubak dsubak commented Nov 22, 2023

Unfortunately, when uploading binaries for the release yesterday, I accidentally uploaded ones built without our modification.

We want our changes built off of memfault/memfault-ecs-cli@75eb585, and I've rebuilt and reuploaded the binaries in https://github.com/memfault/memfault-ecs-cli/releases/tag/1.21.0 to reflect that.

Test Plan

Builds locally with command conda build -c conda-forge .

<output snipped>
export SRC_DIR=/Users/dansubak/mambaforge/envs/build/conda-bld/ecs-cli_1700684638754/test_tmp
+ ecs-cli --version
ecs-cli version 1.21.0 (*75eb585)
+ exit 0

Resource usage statistics from testing ecs-cli:
   Process count: 3
   CPU time: Sys=0:00:00.0, User=0:00:00.0
   Memory: 15.2M
   Disk usage: 24B
   Time elapsed: 0:00:02.0


TEST END: /Users/dansubak/mambaforge/envs/build/conda-bld/osx-arm64/ecs-cli-1.21.0.memfault0-0.conda
Renaming work directory '/Users/dansubak/mambaforge/envs/build/conda-bld/ecs-cli_1700684638754/work' to '/Users/dansubak/mambaforge/envs/build/conda-bld/ecs-cli_1700684638754/work_moved_ecs-cli-1.21.0.memfault0-0_osx-arm64_main_build_loop'
shutil.move(work)=/Users/dansubak/mambaforge/envs/build/conda-bld/ecs-cli_1700684638754/work, dest=/Users/dansubak/mambaforge/envs/build/conda-bld/ecs-cli_1700684638754/work_moved_ecs-cli-1.21.0.memfault0-0_osx-arm64_main_build_loop)
# Automatic uploading is disabled
# If you want to upload package(s) to anaconda.org later, type:


# To have conda build upload to anaconda.org automatically, use
# conda config --set anaconda_upload yes
anaconda upload \
    /Users/dansubak/mambaforge/envs/build/conda-bld/osx-arm64/ecs-cli-1.21.0.memfault0-0.conda
anaconda_upload is not set.  Not uploading wheels: []

INFO :: The inputs making up the hashes for the built packages are as follows:
{
  "ecs-cli-1.21.0.memfault0": {
    "recipe": {}
  }
}

Of note in the above, you can see that ecs-cli --version returns the commit hash we want instead of the old busted one.

Deploy plan

Will kick off another GH Action run to get these built, then upload the resulting binaries as per the README. I'll start with the osx one and test locally to see if bin/setup.py picks up the new binary without additional intervention. Assuming it does, everything should work without any additional work.

@dsubak
Copy link
Contributor Author

dsubak commented Nov 22, 2023

Looks like this ran just fine! https://github.com/memfault/conda-recipes/actions/runs/6962490768

I'll get this guy merged up, test the MacOS version and as long as that's good, we should be able to upload linux and see it hit prod!

@dsubak dsubak merged commit 99a9f1c into master Nov 22, 2023
3 checks passed
@dsubak dsubak deleted the dansubak/202311_use_new_sha_for_actually_modified_bin branch November 22, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants