Update hash to reference newly uploaded binaries #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, when uploading binaries for the release yesterday, I accidentally uploaded ones built without our modification.
We want our changes built off of memfault/memfault-ecs-cli@75eb585, and I've rebuilt and reuploaded the binaries in https://github.com/memfault/memfault-ecs-cli/releases/tag/1.21.0 to reflect that.
Test Plan
Builds locally with command
conda build -c conda-forge .
Of note in the above, you can see that
ecs-cli --version
returns the commit hash we want instead of the old busted one.Deploy plan
Will kick off another GH Action run to get these built, then upload the resulting binaries as per the README. I'll start with the osx one and test locally to see if
bin/setup.py
picks up the new binary without additional intervention. Assuming it does, everything should work without any additional work.