Format generated code only when clang-format is available #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
clang-format
branch
from
ae4a31b
to
672d424
Compare
mickel8
force-pushed
the
clang-format
branch
from
672d424
to
4ac5d78
Compare
mat-hek
requested changes
Dec 15, 2022
lib/unifex/interface_IO.ex
Outdated
| "#{out_base_path}.h #{out_base_path}.c #{out_base_path}.cpp" | ||
| ) | ||
| # Format generated code only when clang-format is available | ||
| if Mix.shell().cmd("whereis clang-format") == 0 do |
There was a problem hiding this comment.
It seems whereis always returns 0 on Mac
iex(1)> System.cmd("whereis", ~w(dupa))
{"dupa:\n", 0}
FelonEkonom
requested changes
Dec 15, 2022
test/test_helper.exs
Outdated
| ExUnit.start() | ||
| # clang-format is required to format the generated code | ||
| # it won't match the reference files otherwise | ||
| case System.cmd("clang-format", ~w(--version)) do |
There was a problem hiding this comment.
System.cmd/2raises%ErlangError{orginal: :enoent}, when it can't find a command- Why do you use one time
$ whereis clang-formatand second time$ clang-formatto check, ifclang-formatis available? - Analogically, why do you use
System.cmd/2in one place, to execute command, butMix.shell().cmd/1in the another place?
There was a problem hiding this comment.
Honestly speaking I don't know what is the difference between System.cmd and Mix.shell().cmd() except that Mix might not be available in the runtime. I moved everything to System
mickel8
force-pushed
the
clang-format
branch
from
9bd4b94
to
ca51652
Compare
mat-hek
approved these changes
Dec 16, 2022
lib/unifex/utils.ex
Outdated
|
|
||
| @spec clang_format_installed?() :: boolean() | ||
| def clang_format_installed?() do | ||
| if System.find_executable("clang-format"), do: true, else: false |
There was a problem hiding this comment.
Suggested change
| if System.find_executable("clang-format"), do: true, else: false | |
| System.find_executable("clang-format") != nil |
FelonEkonom
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't require clang-format to be available on the system. Otherwise, everyone who compiles membrane package and doesn't have clang-format, will get a warning
/usr/bin/sh: 1: clang-format: not found.clang-formatis required in tests so they should remain deterministic.