Allow requesting keyframes and add keyframe information in metadata #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
force-pushed
the
demand-keyframe-events
branch
from
562f206
to
f30d06a
Compare
Noarkhh
force-pushed
the
demand-keyframe-events
branch
from
f89959f
to
ff02b12
Compare
Noarkhh
changed the title
varsill
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Couldn't you somehow disable the keyframe generation on scene change (x264 has a sc_threshold: 0 option for that purpose :D ), set some fixed keyframe interval and then count all the keyframes?
There was a problem hiding this comment.
I'll add the tests once i add the option to specify frame lag in a separate PR (I won't add it in this one, since #6 changes the way config is passed to native functions)
There was a problem hiding this comment.
there is also a possibility that the encoder will finish encoding all frames and only then receive the requesting event
| Element that encodes a VP8 stream | ||
| Element that encodes a VP8 stream. | ||
|
|
||
| This element can receive a `Membrane.VPx.ForceKeyframeEvent` on it's `:output` pad to force the |
There was a problem hiding this comment.
I believe you have forgotten to change the docs here in in vp9_encoder.ex:
Suggested change
| This element can receive a `Membrane.VPx.ForceKeyframeEvent` on it's `:output` pad to force the | |
| This element can receive a `Membrane.KeyframeRequestEvent` on it's `:output` pad to force the |
varsill
reviewed
Jul 26, 2024
varsill
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes membraneframework/membrane_core#840
tests could be better, but i have issues with the fact that the event doesnt always come to the encoder before it produces and buffers a new frame