Fix segment collection end timestamp calculation #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
reviewed
Feb 22, 2024
mat-hek
approved these changes
Feb 22, 2024
mat-hek
reviewed
Feb 22, 2024
mat-hek
reviewed
Feb 23, 2024
Qizot
force-pushed
the
fix-sample-collection-condition
branch
from
fc60864
to
6f5db82
Compare
mat-hek
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When collecting a CMAF segment we are trying to collect the amount of samples whose total duration will exceed certain threshold. Previously the decision was purely based on the end timestamp that took into account only the last sample's DTS while we also need to take into account the sample duration. When the sample duration is pretty small (duration of a single sample e.g. 16ms) the problem was not visible, but when we take into consideration frame gaps between video frames (e.g. 2 seconds) this caused huge mismatches between e.g. audio and video segment durations.