Start forwarding timestamps if they're present in the stream #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
mat-hek
requested changes
Mar 19, 2024
mat-hek
requested changes
Mar 20, 2024
Comment on lines
71
to
73
| after | ||
| 0 -> | ||
| :ok |
There was a problem hiding this comment.
This may finish before the stream ends when a subsequent buffer doesn't arrive at the mailbox on time. Better exit when the end of stream arrives.
There was a problem hiding this comment.
before this receive block we always do assert_end_of_stream, so I don't think that could be the case
mat-hek
requested changes
Mar 25, 2024
Co-authored-by: Mateusz Front <[email protected]>
mat-hek
approved these changes
Mar 26, 2024
Noarkhh
force-pushed
the
forward-timestamps
branch
from
f55a0a2 to
e1ed8c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.