Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release fix #82

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Release fix #82

merged 3 commits into from
Feb 7, 2023

Conversation

mat-hek
Copy link
Member

@mat-hek mat-hek commented Jan 20, 2023

No description provided.

@mat-hek mat-hek requested a review from DominikWolek January 20, 2023 11:18
mix.exs Show resolved Hide resolved
mix.exs Show resolved Hide resolved
@@ -4,6 +4,8 @@
[![API Docs](https://img.shields.io/badge/api-docs-yellow.svg?style=flat)](https://hexdocs.pm/membrane_video_compositor_plugin) -->
[![CircleCI](https://dl.circleci.com/status-badge/img/gh/membraneframework-labs/membrane_video_compositor_plugin/tree/master.svg?style=svg)](https://dl.circleci.com/status-badge/redirect/gh/membraneframework-labs/membrane_video_compositor_plugin/tree/master)

Membrane plugin that accepts multiple video inputs, transforms them according to provided transformations and composes them into a single output video.

It is part of [Membrane Multimedia Framework](https://membraneframework.org).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess usage could be added into the README

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought to do that after the scene API is finished, but can do it now as well. Can I find it somewhere or have to write it from scratch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you have to write it from he scratch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so we can take it from tests, but they're quite sophisticated and I created a story to simplify them: https://membraneframework.atlassian.net/browse/MS-380 So maybe we could solve that first and then create an example based on that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then

@mat-hek mat-hek merged commit 18273f8 into master Feb 7, 2023
@mat-hek mat-hek deleted the release-fix branch February 7, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants