Remove implementation option, VC refactor #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, all mix tests are excluded, due to a lack of GPU and CPU-simulated rendering at the CI server.here is a solution |
WojciechBarczynski
requested review from
Janix4000,
jerzywilczek and
DominikWolek
and removed request for
Janix4000,
jerzywilczek and
DominikWolek
WojciechBarczynski
changed the title
DominikWolek
reviewed
Nov 9, 2022
jerzywilczek
requested changes
Nov 10, 2022
WojciechBarczynski
changed the title
DominikWolek
approved these changes
Nov 16, 2022
jerzywilczek
requested changes
Nov 16, 2022
jerzywilczek
approved these changes
Nov 17, 2022
DominikWolek
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping
implementationoption in pipeline, test etc. seems like unnecessary complication, when we have decided to usewgpu. I think we should delete it. After closing this PR we also should be able to run wgpu tests on CI.