Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ffmpeg compositor native code #2

Merged
merged 35 commits into from
Jul 27, 2022
Merged

Ffmpeg compositor native code #2

merged 35 commits into from
Jul 27, 2022

Conversation

Janix4000
Copy link
Contributor

Implementation of ffmpeg video compositor. It is still simpified version, with hard coded structure of the transformation graph.

@Janix4000 Janix4000 requested a review from DominikWolek July 22, 2022 13:11
@Janix4000 Janix4000 self-assigned this Jul 22, 2022
DominikWolek
DominikWolek reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@DominikWolek DominikWolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review part one

lib/text_overlay_native.ex Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/video_compositor.h Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/video_compositor.spec.exs Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.h Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/video_compositor.spec.exs Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Outdated Show resolved Hide resolved
@Janix4000 Janix4000 requested a review from DominikWolek July 25, 2022 08:07
DominikWolek
DominikWolek suggested changes Jul 25, 2022
View reviewed changes
c_src/ffmpeg_video_compositor/filter.h Outdated Show resolved Hide resolved
test/support/video_compositor_helpers.ex Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Outdated Show resolved Hide resolved
test/video_compositor/video_compositor_ffmpeg_test.exs Outdated Show resolved Hide resolved
test/support/video_compositor_helpers.ex Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Show resolved Hide resolved
c_src/ffmpeg_video_compositor/video_compositor.c Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.h Outdated Show resolved Hide resolved
@Janix4000 Janix4000 requested a review from DominikWolek July 25, 2022 13:16
DominikWolek
DominikWolek suggested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@DominikWolek DominikWolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs overall look ok, just run them through the Grammarly or some other spell checker in case of any missing articles, punctuation errors, etc.

c_src/ffmpeg_video_compositor/filter.h Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.h Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.h Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/video_compositor.c Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/video_compositor.c Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/video_compositor.c Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/video_compositor.c Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
@Janix4000 Janix4000 requested a review from DominikWolek July 26, 2022 09:14
DominikWolek
DominikWolek suggested changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@DominikWolek DominikWolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the formatting to the code.

c_src/ffmpeg_video_compositor/filter.h Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.h Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.h Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.h Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Outdated Show resolved Hide resolved
c_src/ffmpeg_video_compositor/filter.c Outdated Show resolved Hide resolved
DominikWolek
DominikWolek approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@DominikWolek DominikWolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
approval-1

@Janix4000 Janix4000 merged commit f4d3072 into master Jul 27, 2022
@Janix4000 Janix4000 deleted the ffmpeg-compositor branch July 27, 2022 07:19
WojciechBarczynski pushed a commit that referenced this pull request Aug 9, 2022
@Janix4000
Merge pull request #2 from membraneframework-labs/ffmpeg-compositor
3105a20 
Ffmpeg compositor native code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikWolek DominikWolek DominikWolek approved these changes

Assignees

@Janix4000 Janix4000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janix4000 @DominikWolek