Bump membrane core version to 1.0 for VideoCompositor SDK, flatten examples file structure #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechBarczynski
changed the title
WojciechBarczynski
changed the base branch from
master
to
video_compositor_sdk
mat-hek
requested changes
Nov 24, 2023
WojciechBarczynski
changed the title
examples/lib/dynamic_outputs.exs
Outdated
| @@ -1,7 +1,202 @@ | |||
| alias Membrane.VideoCompositor.Examples.DynamicOutputs.Pipeline | |||
| defmodule DynamicOutputsPipeline do | |||
There was a problem hiding this comment.
Everything here is copy-pasted from deleted files
mat-hek
reviewed
Nov 24, 2023
There was a problem hiding this comment.
ok, now you can move the .exs files out of the lib directory and fix readme https://github.com/membraneframework/membrane_video_compositor_plugin/tree/bump_membrane_core_version#examples and I think we can merge ;)
mat-hek
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.