Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement live queueing strategy and callbacks system #111

Merged
merged 93 commits into from
Jun 28, 2023
Merged

Implement live queueing strategy and callbacks system #111

merged 93 commits into from
Jun 28, 2023

Conversation

WojciechBarczynski
Copy link
Member

@WojciechBarczynski
Add offline queue element. Change new-compositor scene to old API. …
33f9123 
…Remove scene related modules
@WojciechBarczynski
Add updating stream format, scene and sending buffer test. Fix queue …
763040e 
…element
@WojciechBarczynski
Fix recursive frames poping
b54e619
@WojciechBarczynski
Fix droping pads
5d5e2fd
@WojciechBarczynski
Add queue tests, fix and refactor events poping, actions, pads removi…
382dfe2 
…ng and logic separation
@WojciechBarczynski
Add update scene events handling
4a151d0
@WojciechBarczynski
Add update scene events handling test
8cc121d
@WojciechBarczynski
Add docs
9d3bc95
@WojciechBarczynski
Add CompositorCoreFormat docs
d941890
@WojciechBarczynski
Renamed queue output from :compositor_core to :output
4ad282c
@WojciechBarczynski
Fix EOS action
b9e0c52
@WojciechBarczynski
Fix readability
f6793d1
@WojciechBarczynski
Add module for queue contracts
e73a134
@WojciechBarczynski
Fix calculate_next_buffer_pts readability
85e2b33
@WojciechBarczynski
Fix EOS handling add EOS test
9682a7f
@WojciechBarczynski
Fix lint
f1e665d
@WojciechBarczynski
Adjust core VC to the new input format from the queue.
8b6660b
@WojciechBarczynski
Change setting video. Update VC Core, VC bin, add `Offline Queue …
1fea81b 
…bin`, update tests
@WojciechBarczynski
Naming fixes
45a323a
@WojciechBarczynski
Merge branch master into adjust_vc_core_to_new_queue
10f4316
@WojciechBarczynski
Fix scene notification event and rust decoding
9fd396a
@WojciechBarczynski
Fix tests
2eb1c59
@WojciechBarczynski
Fix dirty scheduling
7569b0d
@WojciechBarczynski
Add docs
bbf1707
@WojciechBarczynski
Use Map.new instead of Map -> Enum -> Map conversions
0fe5e0a
@WojciechBarczynski
Remove wgpu_test - covered in E2E tests
5a5edfb
@WojciechBarczynski
Fix pad_ref offline queue pad refs handling
68f7d0a
@WojciechBarczynski
Fix handle_pad_removed
dd99e91
@WojciechBarczynski
Fix plural variables naming
f0ae43b
@WojciechBarczynski
Move queue spawing logic to seperate module
5f68419
@WojciechBarczynski WojciechBarczynski marked this pull request as ready for review June 23, 2023 21:46
varsill
varsill requested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@varsill varsill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also wondering if the Queue.Live and Queue.Offline shouldn't be put in a separate namespace, e.g. Queue.Strategies.*, so that they are not on the same level as Queue.State - WDYT?

lib/membrane/video_compositor/queue/state/handler_state.ex Outdated Show resolved Hide resolved
lib/membrane/video_compositor/queue/state/handler_state.ex Outdated Show resolved Hide resolved
lib/membrane/video_compositor/queue/state/handler_state.ex Outdated Show resolved Hide resolved
lib/membrane/video_compositor/queue/state/pad_state.ex Outdated Show resolved Hide resolved
lib/membrane/video_compositor/queue/state/pad_state.ex Outdated Show resolved Hide resolved
lib/membrane/video_compositor/video_compositor.ex Outdated Show resolved Hide resolved
lib/membrane/video_compositor/video_compositor.ex Outdated Show resolved Hide resolved
lib/membrane/video_compositor/queue.ex Outdated Show resolved Hide resolved
test/support/pipelines/options.ex Outdated Show resolved Hide resolved
test/live_queue_test.exs Show resolved Hide resolved
varsill
varsill reviewed Jun 28, 2023
View reviewed changes
lib/membrane/video_compositor/queue/contracts.ex Outdated Show resolved Hide resolved
lib/membrane/video_compositor/queue/strategies/offline/element.ex Outdated Show resolved Hide resolved
test/live_queue_test.exs Outdated Show resolved Hide resolved
test/live_queue_test.exs Outdated Show resolved Hide resolved
varsill
varsill approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@varsill varsill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@WojciechBarczynski WojciechBarczynski merged commit 7c7cf01 into master Jun 28, 2023
@WojciechBarczynski WojciechBarczynski deleted the MS_444_implement_live_queueing_strategy branch June 28, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varsill varsill varsill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojciechBarczynski @varsill