Change caps #9
Closed
Change caps #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maksstach
commented
Dec 6, 2021
maksstach
commented
- allow vp8/vp9 input caps
- allow passing stream parameters via caps
- allow serializing without providing width or height
This was referenced Dec 6, 2021
andpodob
suggested changes
Dec 7, 2021
lib/deserializer.ex
Outdated
| @@ -91,7 +97,7 @@ defmodule Membrane.Element.IVF.Deserializer do | |||
| Headers.parse_ivf_frame_header(payload), | |||
| <<frame::binary-size(size_of_frame), rest::binary()>> <- rest do | |||
| timestamp = timestamp * (timebase * Time.second()) | |||
| {:ok, %Buffer{metadata: %{timestamp: timestamp}, payload: frame}, rest} | |||
| {:ok, %Buffer{pts: timestamp, payload: frame}, rest} | |||
There was a problem hiding this comment.
Below in line 102 you can remove this {:error_too_short, payload} as it is not handled anyways. It should work with skipping the else block.
There was a problem hiding this comment.
it is used in line 72
lib/serializer.ex
Outdated
| if state.first_frame do | ||
| if state.width == 0 or state.height == 0, | ||
| do: | ||
| IO.warn("Serializing stream to IVF without width or height given via options or caps") |
There was a problem hiding this comment.
Suggested change
| IO.warn("Serializing stream to IVF without width or height given via options or caps") | |
| IO.warn("Serializing stream to IVF without width or height. These parameters can be passed via options or caps") |
lib/serializer.ex
Outdated
|
|
||
| ivf_buffer = (ivf_file_header || "") <> ivf_frame | ||
|
|
||
| {{:ok, buffer: {:output, %Buffer{buffer | payload: ivf_buffer}}, redemand: :output}, | ||
| %State{state | first_frame: false}} | ||
| end | ||
|
|
||
| defp update_state(state, new_fields) do |
There was a problem hiding this comment.
update_state and new_fields are not really descriptive and self-explanatory, we need to find some better names for them. Maybe apply_caps_to_state or update_state_with_caps, and new_field -> caps.
added 2 commits
December 8, 2021 12:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.