Replace realpath with Path.expand #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
reviewed
Mar 6, 2024
FelonEkonom
requested review from
mat-hek and
varsill
and removed request for
varsill
mat-hek
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Since it seems that the lack of realpath is the only thing that currently prevents Bundlex from working on a clean Mac OS, I'd instead use :file.read_link. Since it works only for symlinks, it would probably require having Bundlex.Toolchain.real_output_path that would check if priv is a symlink and resolve it's real path in that case.
|
@mickel8 it should work without |
FelonEkonom
approved these changes
Apr 9, 2024
test/bundlex/integration_test.exs
Outdated
|
|
||
| target_path | ||
| end | ||
| Enum.map([false, true], fn priv -> |
There was a problem hiding this comment.
Suggested change
| Enum.map([false, true], fn priv -> | |
| Enum.map([false, true], fn priv? -> |
|
It works, the only things is taht |
mat-hek
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
realpathmight not be installed on some OSes. I wonder if we could just usePath.expandinstead, like in the PR?