Release v1.4.6 and bugfix of symlink to priv/ creation #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iv/ creation not fail if the directory already exists
mat-hek
reviewed
Feb 12, 2024
| create_relative_symlink(lib_path, logical_output_path, logical_dep_dir_name) | ||
|
|
||
| {physical_output_path, 0} = System.shell("realpath #{logical_output_path}") | ||
| physical_output_path = String.slice(physical_output_path, 0..-2//1) |
There was a problem hiding this comment.
use String.trim or trim_trailing
| logical_output_path = Bundlex.Toolchain.output_path(native.app, native.interface) | ||
| create_relative_symlink(lib_path, logical_output_path, logical_dep_dir_name) | ||
|
|
||
| {physical_output_path, 0} = System.shell("realpath #{logical_output_path}") |
There was a problem hiding this comment.
let's add a comment on why we do this and create two symlinks
mat-hek
approved these changes
Feb 12, 2024
FelonEkonom
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
.sofiles forpriv/in_buildbeing both a directory and for a symlink